HyukjinKwon commented on a change in pull request #31698:
URL: https://github.com/apache/spark/pull/31698#discussion_r585328604
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
##########
@@ -53,31 +53,31 @@ private[sql] class JSONOptions(
val samplingRatio =
parameters.get("samplingRatio").map(_.toDouble).getOrElse(1.0)
val primitivesAsString =
- parameters.get("primitivesAsString").map(_.toBoolean).getOrElse(false)
+ parameters.get("primitivesAsString").exists(_.toBoolean)
Review comment:
I know this calls less but I wonder if it is really more readable. To me
`map(_).getOrElse(false)` looks more readable: if exists convert to a bool, and
defaults `false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
