sarutak opened a new pull request #31706:
URL: https://github.com/apache/spark/pull/31706


   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class 
hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other 
DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This PR proposes a new feature that allows developers to debug test code 
using JDWP with sbt.
   More specifically, this PR introduced the following options for sbt.
   
   * `test.jdwp.enabled`: Flat which controls JDWP enabled or disabled for tests
   * `test.jdwp.address`: An option which corresponds to `address` option in 
JDWP
   * `test.jdwp.suspend`: An option which corresponds to `suspend` option in 
JDWP
   * `test.jdwp.server`: An option which corresponds to `server` option in JDWP
   
   We can use these options like `build/sbt -Dtest.jdwp.enabled=true 
-Dtest.jdwp.address=localhost:9876 -Dtest.jdwp.suspend=y -Dtest.jdwp.server=y` 
and can be used for both JUnit tests and ScalaTest tests.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   It's useful to debug test code.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   I confirmed the following things.
   
   * `test.jdwp.enabled` can switch JDWP enabled/disabled
   * `test.jdwp.address` can change address and port.
   * `test.jdwp.suspend` can change the behavior that the target debugee 
suspends or not.
   * `test.jdwp.server` can change the behavior that the JDWP debugger run as a 
server or client.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to