cloud-fan commented on a change in pull request #31477:
URL: https://github.com/apache/spark/pull/31477#discussion_r585673885
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -57,7 +57,8 @@ case class BroadcastHashJoinExec(
}
override lazy val metrics = Map(
- "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"))
+ "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
+ "numMatchedRows" -> SQLMetrics.createMetric(sparkContext, "number of
matched rows"))
Review comment:
This seems like a "progress bar" instead of a metrics. Most likely
people don't care about it because it's usually `num output rows of left` *
`num output rows of right`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
