HeartSaVioR commented on a change in pull request #31580:
URL: https://github.com/apache/spark/pull/31580#discussion_r586307215
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/SortDirection.java
##########
@@ -19,14 +19,33 @@
import org.apache.spark.annotation.Experimental;
+import static
org.apache.spark.sql.connector.expressions.NullOrdering.NULLS_FIRST;
+import static
org.apache.spark.sql.connector.expressions.NullOrdering.NULLS_LAST;
+
/**
* A sort direction used in sorting expressions.
+ * <p>
+ * Each direction has a default null ordering that is implied if no null
ordering is specified
+ * explicitly.
*
* @since 3.2.0
*/
@Experimental
public enum SortDirection {
- ASCENDING, DESCENDING;
+ ASCENDING(NULLS_FIRST), DESCENDING(NULLS_LAST);
+
+ private final NullOrdering defaultNullOrdering;
+
+ SortDirection(NullOrdering defaultNullOrdering) {
+ this.defaultNullOrdering = defaultNullOrdering;
+ }
+
+ /**
+ * Returns the default null ordering to use if no null ordering is specified
explicitly.
+ */
+ public NullOrdering defaultNullOrdering() {
Review comment:
Ah OK. I was misunderstood about the usage on SortOrder. If the users (I
assume this includes data source implementation) are discouraged to implement
this, no problem at all and please disregard my comments.
I understand the catalyst module is considered as private API, but given
connector package is now playing as public API (at least some of APIs are
public API data source implementations should leverage), it'd be nice if we
could explicitly separate the public vs private APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
