yikf commented on a change in pull request #31664:
URL: https://github.com/apache/spark/pull/31664#discussion_r586279580
##########
File path:
core/src/test/scala/org/apache/spark/shuffle/sort/SortShuffleManagerSuite.scala
##########
@@ -131,4 +138,33 @@ class SortShuffleManagerSuite extends SparkFunSuite with
Matchers {
)))
}
+ Seq("true", "false").foreach { value =>
+ test(s"SPARK-34541: shuffle can be removed when
spark.shuffle.useOldFetchProtocol=$value") {
Review comment:
If we move it to `ShuffleSuite`, we should consider the case of
`spark.shuffle.useOldFetchProtoclol = false` , and different configurations
are also more intuitive to test together.
If we need to move it to ShuffleSuite, I'm alse ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
