AngersZhuuuu commented on a change in pull request #31721:
URL: https://github.com/apache/spark/pull/31721#discussion_r586386840
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
##########
@@ -53,6 +53,16 @@ case class AddFileCommand(path: String) extends
RunnableCommand {
}
}
+/**
+ * Adds an archive to the current session so it can be used.
+ */
+case class AddArhiveCommand(path: String) extends RunnableCommand {
Review comment:
`AddArchiveCommand`?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -375,6 +376,12 @@ class SparkSqlAstBuilder extends AstBuilder {
} else {
ListJarsCommand()
}
+ case "archive" | "archives" =>
Review comment:
just keep consistence `"archives" | "archive"`
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
##########
@@ -100,3 +110,24 @@ case class ListJarsCommand(jars: Seq[String] =
Seq.empty[String]) extends Runnab
}
}
}
+
+/**
+ * Returns a list of archive paths that are added to resources.
+ * If file paths are provided, return the ones that are added to resources.
Review comment:
`archive file paths` or `archive paths`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
