c21 commented on a change in pull request #31715:
URL: https://github.com/apache/spark/pull/31715#discussion_r586988087
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -2034,7 +2034,8 @@ private[spark] class DAGScheduler(
// if the cluster manager explicitly tells us that the entire worker was
lost, then
// we know to unregister shuffle output. (Note that "worker" specifically
refers to the process
// from a Standalone cluster, where the shuffle service lives in the
Worker.)
- val fileLost = workerHost.isDefined ||
!env.blockManager.externalShuffleServiceEnabled
+ val fileLost = (workerHost.isDefined ||
!env.blockManager.externalShuffleServiceEnabled) &&
+ env.blockManager.markFileLostOnExecutorLost
Review comment:
shouldn't we check this config to not take effect, if
`spark.shuffle.manager` is `sort` (the default one)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
