Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/580#discussion_r12257998
  
    --- Diff: make-distribution.sh ---
    @@ -43,12 +43,13 @@
     FWDIR="$(cd `dirname $0`; pwd)"
     DISTDIR="$FWDIR/dist"
     
    -VERSION=$(mvn help:evaluate -Dexpression=project.version | grep -v "INFO" 
| tail -n 1)
    -if [ $? == -1 ] ;then
    +VERSION_TEXT=$(mvn help:evaluate -Dexpression=project.version 2>/dev/null)
    --- End diff --
    
    Rather than capture an intermediate variable here, could you instead just 
do:
    ```
    set -o pipefail
    ```
    
    To make sure the failure is propagated outside of the pipeline?
    
    I think it's a bit simpler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to