ulysses-you commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587233273
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with
SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
We don't use the `SQLConf.get` to do the view analysis, instead we use
the `new SQLConf()`. So we always use the default value `false`. See some
related code in `View` below
```
def effectiveSQLConf(configs: Map[String, String], isTempView: Boolean):
SQLConf = {
val activeConf = SQLConf.get
// For temporary view, we always use captured sql configs
if (activeConf.useCurrentSQLConfigsForView && !isTempView) return
activeConf
val sqlConf = new SQLConf()
for ((k, v) <- configs) {
sqlConf.settings.put(k, v)
}
sqlConf
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
