c21 commented on a change in pull request #31736:
URL: https://github.com/apache/spark/pull/31736#discussion_r587861479
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/JoinBenchmark.scala
##########
@@ -178,6 +191,7 @@ object JoinBenchmark extends SqlBasedBenchmark {
sortMergeJoin()
sortMergeJoinWithDuplicates()
shuffleHashJoin()
+ broadcastNestedLoopJoin()
Review comment:
@wangyum - sure, I noticed the original benchmark was running on
`OpenJDK 64-Bit Server VM 1.8.0_232-8u232-b09-0ubuntu1~18.04.1-b09 on Linux
4.15.0-1044-aws` in [result
file](https://github.com/apache/spark/blob/f5118f81e395bde0cd8253dbef6a9e6455c3958a/sql/core/benchmarks/JoinBenchmark-results.txt#L5).
Should I try to run benchmark in the same type of machine? or this is not a
hard requirement. cc @maropu as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
