Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5669#issuecomment-96816164
After discussing with @mengxr I think we should not bother with the
try-finally wrapper. As mentioned above, the method should generally not fail,
so the data will be unpersisted as needed. When an exception is thrown, then
the data will be unpersisted whenever another RDD pushes "input" out of
memory/disk, without undue harm to other jobs.
@jimfcarroll Could you please update the PR to remove the try-finally
wrapper, but keep the unpersist at the end?
Thanks for going through this discussion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
