wangyum commented on a change in pull request #31739:
URL: https://github.com/apache/spark/pull/31739#discussion_r588183649
##########
File path:
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q32.sf100/explain.txt
##########
@@ -1,35 +1,37 @@
== Physical Plan ==
-CollectLimit (31)
-+- * Project (30)
- +- * BroadcastHashJoin Inner BuildRight (29)
- :- * Project (27)
- : +- * BroadcastHashJoin Inner BuildLeft (26)
- : :- BroadcastExchange (22)
- : : +- * Project (21)
- : : +- * BroadcastHashJoin Inner BuildLeft (20)
- : : :- BroadcastExchange (5)
- : : : +- * Project (4)
- : : : +- * Filter (3)
- : : : +- * ColumnarToRow (2)
- : : : +- Scan parquet default.item (1)
- : : +- * Filter (19)
- : : +- * HashAggregate (18)
- : : +- Exchange (17)
- : : +- * HashAggregate (16)
- : : +- * Project (15)
- : : +- * BroadcastHashJoin Inner BuildRight
(14)
- : : :- * Filter (8)
- : : : +- * ColumnarToRow (7)
- : : : +- Scan parquet
default.catalog_sales (6)
- : : +- BroadcastExchange (13)
- : : +- * Project (12)
- : : +- * Filter (11)
- : : +- * ColumnarToRow (10)
- : : +- Scan parquet
default.date_dim (9)
- : +- * Filter (25)
- : +- * ColumnarToRow (24)
- : +- Scan parquet default.catalog_sales (23)
- +- ReusedExchange (28)
+CollectLimit (33)
++- * Project (32)
+ +- * LocalLimit (31)
+ +- * Project (30)
+ +- * BroadcastHashJoin Inner BuildRight (29)
Review comment:
@c21 @maropu Push down `LocalLimit` through `Project` can not benefit
this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
