dongjoon-hyun commented on pull request #31709: URL: https://github.com/apache/spark/pull/31709#issuecomment-791778188
Ya. I agree with you the following. > I think that intent is fulfilled with the fix in this PR when running in non-testing mode -- the codegen fallback to interpreter would step in and make it work, instead of getting a JDK java.lang.InternalError that Spark's codegen doesn't handle. And, in that case, we should wrap the unit test case with `CODEGEN_FACTORY_MODE` setting explicitly because it works only in the fallback status. So, are you going to proceed in revise the test case in that way, @rednaxelafx ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
