attilapiros commented on a change in pull request #30004:
URL: https://github.com/apache/spark/pull/30004#discussion_r588833956
##########
File path: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala
##########
@@ -147,13 +171,18 @@ class MapOutputTrackerSuite extends SparkFunSuite {
intercept[FetchFailedException] {
mapWorkerTracker.getMapSizesByExecutorId(10, 0) }
val size1000 = MapStatus.decompressSize(MapStatus.compressSize(1000L))
- masterTracker.registerMapOutput(10, 0, MapStatus(
- BlockManagerId("a", "hostA", 1000), Array(1000L), 5))
+ val mapStatus = MapStatus(BlockManagerId("a", "hostA", 1000),
Array(1000L), 5)
+ masterTracker.registerMapOutput(10, 0, mapStatus)
mapWorkerTracker.updateEpoch(masterTracker.getEpoch)
assert(mapWorkerTracker.getMapSizesByExecutorId(10, 0).toSeq ===
Seq((BlockManagerId("a", "hostA", 1000),
ArrayBuffer((ShuffleBlockId(10, 5, 0), size1000, 0)))))
- assert(0 == masterTracker.getNumCachedSerializedBroadcast)
+ val allMapOutputStatuses = mapWorkerTracker.getAllMapOutputStatuses(10)
+ assert(allMapOutputStatuses.length === 1)
+ assert(allMapOutputStatuses(0).location === mapStatus.location)
Review comment:
I would prefer to have an `equals` method on `MapStatus` and use the
equals here.
Because in that case when `MapStatus` is extended with a new field this test
will validate the serialization / deserialization of this new field too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
