HeartSaVioR commented on a change in pull request #31761:
URL: https://github.com/apache/spark/pull/31761#discussion_r589100405



##########
File path: 
core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
##########
@@ -119,7 +133,7 @@ private[deploy] class HadoopFSDelegationTokenProvider
     val renewer = UserGroupInformation.getCurrentUser().getUserName()
 
     val creds = new Credentials()
-    fetchDelegationTokens(renewer, filesystems, creds)
+    fetchDelegationTokens(renewer, filesystems, creds, hadoopConf, sparkConf)
 
     val renewIntervals = creds.getAllTokens.asScala.filter {

Review comment:
       Just curious, suppose we have a fs which we exclude the renewal, then my 
understanding on behavior is it fetches the delegation token but won't renew. 
Do I understand correctly? Just curious about how these credentials will be 
handled from here, like whether they're not 
`AbstractDelegationTokenIdentifier`, or `token.renew` fails but Try will 
swallow.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to