[GitHub] [spark] HyukjinKwon opened a new pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Sun, 07 Mar 2021 17:22:56 -0800 


HyukjinKwon opened a new pull request #31773:
URL: https://github.com/apache/spark/pull/31773


   ### What changes were proposed in this pull request?
   
   Currently Binder link at Spark 3.1.1 
(https://mybinder.org/v2/gh/apache/spark/v3.1.1-rc3?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart.ipynb)
 shows  `v3.1.1-rc3` like:
   ![Screen Shot 2021-03-08 at 10 10 55 
AM](https://user-images.githubusercontent.com/6477701/110262729-ecb70880-7ff7-11eb-92ba-f151d74985a6.png)
   
   After the fix, it will shows the explicit hash:
   
   ![Screen Shot 2021-03-08 at 10 17 25 
AM](https://user-images.githubusercontent.com/6477701/110262740-f476ad00-7ff7-11eb-8632-5b418ff87024.png)
   
   Note that it is hash in order to make both dev and release easier.
   
   ### Why are the changes needed?
   
   To hide RC tags.
   
   ### Does this PR introduce _any_ user-facing change?
   
   It will just change the URL shown when Binder is being loaded.
   
   ### How was this patch tested?
   
   Manually tested:
   
   ```bash
   make clean html
   ```
   
   ![Screen Shot 2021-03-08 at 10 17 06 
AM](https://user-images.githubusercontent.com/6477701/110262813-2ee04a00-7ff8-11eb-9983-c4484f7832c4.png)
   
   
   ```bash
   git_hash=`git rev-parse --short HEAD`
   export GIT_HASH=$git_hash
   make clean html
   ```
   
   ![Screen Shot 2021-03-08 at 10 17 25 
AM](https://user-images.githubusercontent.com/6477701/110262805-2982ff80-7ff8-11eb-8560-e1e2aa7b263a.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to