cloud-fan commented on a change in pull request #31764:
URL: https://github.com/apache/spark/pull/31764#discussion_r589170423
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala
##########
@@ -51,6 +51,15 @@ trait CodegenInterpretedPlanTest extends PlanTest {
super.test(testName + " (interpreted path)", testTags: _*)(testFun)(pos)
}
}
+
+ protected def testFallback(
Review comment:
The current test framework assumes that codegen and non-codegen should
have consistent behaviors, while this codegen bug breaks the assumption. The
test case fails with codegen but passes with non-codegen.
+1 to add this for such test cases. One thing I'm curious about is why this
test works in master...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
