cloud-fan commented on a change in pull request #31740:
URL: https://github.com/apache/spark/pull/31740#discussion_r589271430
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -946,6 +947,45 @@ object TransposeWindow extends Rule[LogicalPlan] {
}
}
+/**
+ * Replaces duplicate window expressions with an alias in a Project above the
Window node.
+ */
+object RemoveDuplicateWindowExprs extends Rule[LogicalPlan] {
Review comment:
Shall we do the same thing for project and aggregate? Another big idea
is to re-implement subexpression elimination in the plan level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
