WeichenXu123 commented on a change in pull request #31693:
URL: https://github.com/apache/spark/pull/31693#discussion_r589321782
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
##########
@@ -824,6 +843,44 @@ class LogisticRegressionSuite extends MLTest with
DefaultReadWriteTest {
assert(model6.coefficients ~= coefficientsExpected5 relTol 1E-3)
}
+ test("SPARK-34448: binary logistic regression with intercept with features
with small var") {
+ val trainer1 = new
LogisticRegression().setFitIntercept(true).setStandardization(true)
+ .setWeightCol("weight")
+ val trainer2 = new
LogisticRegression().setFitIntercept(true).setStandardization(false)
+ .setWeightCol("weight")
+
Review comment:
add test for small var features + reg > 0 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
