Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5616#discussion_r29207037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -89,6 +89,17 @@ abstract class BinaryExpression extends Expression with
trees.BinaryNode[Express
override def toString: String = s"($left $symbol $right)"
}
+/**
+ * This class is for expressions that use math functions like `pow`,
`max`, `hypot`, and `atan2`,
+ * which can't be expressed as `$left $symbol $right`. They are expressed
as
+ * `$func($left, $right)`.
+ */
+abstract class BinaryFunctionExpression extends Expression with
trees.BinaryNode[Expression] {
--- End diff --
is the only difference toString? In that case can't we just override
toString in BinaryMathExpression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
