sarutak commented on a change in pull request #31754:
URL: https://github.com/apache/spark/pull/31754#discussion_r589533107
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -141,8 +140,7 @@ case class UnresolvedTableValuedFunction(
*/
case class UnresolvedAttribute(nameParts: Seq[String]) extends Attribute with
Unevaluable {
- def name: String =
- nameParts.map(n => if (n.contains(".")) s"`$n`" else n).mkString(".")
+ def name: String = nameParts.map(n => if (n.contains(".")) s"`$n`" else
n).mkString(".")
Review comment:
With this change, ```UnresolvedAttribute("`a.b`"::"c.d"::Nil).sql```
returns
```
``a.b``.`c.d`
```
Not
```
```a.b```.`c.d`
```
And I think this is correct because ``` ` ``` should be quoted.
I mistakenly change this line, which is not `sql` but is `name`. As you see,
there is no effective change here.
I'll revert the change of this line.
I think `name` also has similar issue bat I'd like focus `sql` in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
