maropu commented on a change in pull request #31721:
URL: https://github.com/apache/spark/pull/31721#discussion_r589847004
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -857,6 +857,47 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
assert(sql(s"list file $testFile").count() == 1)
}
+ test("ADD ARCHIVE command") {
+ withTempDir { dir =>
+ val file1 = File.createTempFile("someprefix1", "somesuffix1", dir)
+ val zipFile = new File(dir, "test.zip")
+ val file2 = File.createTempFile("someprefix2", "somesuffix2", dir)
+ // Emulate unsupported archive format with .bz2 suffix.
+ val unsupportedArchive = new File(dir, "test.bz2")
Review comment:
Could you split this single test unit into smaller meaningful units?
e.g.,
```
test("ADD ARCHIVE/LIST ARCHIVES commands") { ... }
test("ADD ARCHIVE command - unsupported archive formats") { ... }
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
