cloud-fan commented on a change in pull request #31646:
URL: https://github.com/apache/spark/pull/31646#discussion_r590443079
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -767,6 +771,10 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
if useAdvanced =>
Some(convertInToOr(name, values))
+ case Not(In(ExtractAttribute(SupportedAttribute(name)),
ExtractableLiterals(values)))
Review comment:
`Not(a IN (null, 2))`: if a = 1, the final result is null.
`a != 2`: if a = 1, the final result is true
I think this rewrite is incorrect. We need to make sure the values of IN are
all not null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
