andygrove opened a new pull request #31793:
URL: https://github.com/apache/spark/pull/31793


   ### What changes were proposed in this pull request?
   There is a regression in 3.1.1 compared to 3.0.2 when checking for a 
canonicalized plan when executing CustomShuffleReaderExec.
   
   The regression was caused by the call to `sendDriverMetrics` which happens 
before the check and will always fail if the plan is canonicalized.
   
   ### Why are the changes needed?
   This is a regression in a useful error check.
   
   ### Does this PR introduce _any_ user-facing change?
   No. This is not an error that a user would typically see, as far as I know.
   
   ### How was this patch tested?
   I tested this change locally by making a distribution from this PR branch. 
Before fixing the regression I saw:
   
   ```
   java.util.NoSuchElementException: key not found: numPartitions
   ```
   
   After fixing this regression I saw:
   
   ```
   java.lang.IllegalStateException: operating on canonicalized plan
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to