tanelk commented on pull request #31797: URL: https://github.com/apache/spark/pull/31797#issuecomment-795499515
The `NullPropagation` applies to all expressions, but `ReplaceNullWithFalseInPredicate` changes only `Filter`, `Join` and some others. So if I would write the results of `Not(1 IN (1, NULL))` to file, then this rule would change it from `false` to `null`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org