wangyum commented on a change in pull request #29726:
URL: https://github.com/apache/spark/pull/29726#discussion_r591671088
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -147,10 +163,15 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper {
case _ => fallbackRatio
}
+ val estimatePruningSideSize = filterRatio *
partPlan.stats.sizeInBytes.toFloat
// the pruning overhead is the total size in bytes of all scan relations
val overhead =
otherPlan.collectLeaves().map(_.stats.sizeInBytes).sum.toFloat
-
- filterRatio * partPlan.stats.sizeInBytes.toFloat > overhead.toFloat
+ if (canBuildBroadcast) {
+ estimatePruningSideSize > overhead
+ } else {
+ // We need to ensure that the otherPlan can collect to the driver.
+ canBroadcastBySize(otherPlan, SQLConf.get) && estimatePruningSideSize *
0.04 > overhead
Review comment:
This is to ensure that the pruning side is much lager, after all, we
cannot reuse broadcast. For example.
If overhead = 10M
| canBuildBroadcast | canNotBuildBroadcast
-- | -- | --
hasBenefit=true | estimatePruningSideSize > 20M | estimatePruningSideSize >
500M
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
