c21 commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592070353
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
##########
@@ -103,7 +103,7 @@ class ExistenceJoinSuite extends SparkPlanTest with
SharedSparkSession {
ProjectExec(output, FilterExec(condition, join))
}
- test(s"$testName using ShuffledHashJoin") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using ShuffledHashJoin") { _
=>
Review comment:
@dongjoon-hyun - if the purpose of separating PRs is to merge change to
other branches as well, I can submit another PR for all test-related change,
i.e. the change in `InnerJoinSuite.scala`, `OuterJoinSuite.scala` and
`ExistenceJoinSuite.scala`.
Do we want to do that? These test changes are valid to be merged into `3.1`
branch as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]