Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5616#discussion_r29212988
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -643,4 +644,26 @@ trait HiveTypeCoercion {
}
}
+ /**
+ * Casts types according to the expected input types for Expressions
that have the trait
+ * `ExpectsInputTypes`.
+ */
+ object ExpectedInputConversion extends Rule[LogicalPlan] {
+
+ def apply(plan: LogicalPlan): LogicalPlan = plan
transformAllExpressions {
+ // Skip nodes who's children have not been resolved yet.
+ case e if !e.childrenResolved => e
+
+ case e: ExpectsInputTypes if e.children.map(_.dataType) !=
e.expectedChildTypes =>
+ val newC = (e.children, e.children.map(_.dataType),
e.expectedChildTypes).zipped.map {
+ case (child, actual, expected) =>
+ if (actual == expected) {
--- End diff --
if u need to update the PR again, maybe collapse this into a single line,
i.e.
```scala
if (actual == expected) child else Cast(child, expected)
```
if you don't need to update it then don't do it just for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
