viirya commented on a change in pull request #31758:
URL: https://github.com/apache/spark/pull/31758#discussion_r592136289
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala
##########
@@ -80,11 +80,7 @@ class RelationalGroupedDataset protected[sql](
}
}
- // Wrap UnresolvedAttribute with UnresolvedAlias, as when we resolve
UnresolvedAttribute, we
- // will remove intermediate Alias for ExtractValue chain, and we need to
alias it again to
- // make it a NamedExpression.
Review comment:
Hmm, this code is pretty old, 2015.
I saw `alias` is also used to add alias around grouping expressions, not
just aggregate expressions. Seems the comment is more for the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
