Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5645#discussion_r29213656
--- Diff:
streaming/src/main/java/org/apache/spark/streaming/util/WriteAheadLogSegment.java
---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.streaming.util;
+
+/**
+ * This is an interface that represent the information required by any
implementation of
+ * a WriteAheadLog to read a written record.
+ */
[email protected]
+public interface WriteAheadLogSegment extends java.io.Serializable {
--- End diff --
But in the current approach, they can't for instance use kryo or protobuf
to serialize, unless they do something really crazy like use an externalizable
hook to then call into Kryo. I guess I'm just thinking ahead to how this will
evolve. However, if we want to have this in the future we can always create an
alternative version that is additive, so I don't feel strongly at all
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
