dannymeijer commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-798893806


   > Thank you for your proposal @dannymeijer.
   > 
   > I'd probably follow Scala side here and use `Any` here:
   > 
   > ```python
   > def contains(self, item: Any) -> Column: ...
   > ```
   > 
   > ‒ while it is not that useful, calls like
   > 
   > ```
   > >>> spark.range(1).select(lit("it is true").contains(True)).show()
   > +--------------------------+
   > |contains(it is true, true)|
   > +--------------------------+
   > |                      true|
   > +--------------------------+
   > ```
   > 
   > or
   > 
   > ```
   > >>> spark.range(1).select(lit("it is true").contains(True)).show()
   > +--------------------------+
   > |contains(it is true, true)|
   > +--------------------------+
   > |                      true|
   > +--------------------------+
   > ```
   > 
   > are technically speaking valid.
   > 
   > Could you add `[PYTHON][SQL]` to the title?
   
   Fair point! Changed it accordingly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to