HeartSaVioR commented on a change in pull request #31826:
URL: https://github.com/apache/spark/pull/31826#discussion_r594007189
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -3003,6 +3003,12 @@ private[spark] object Utils extends Logging {
resultProps
}
+ /** Create a new properties object with the same values as `props` while
handling null case */
Review comment:
I'd rather say we'd be better to fix `cloneProperties` to handle null
for props instead: it just throws NPE now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
