GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/5740
[SPARK-7176] [ml] Add validation functionality to Param
Main change: Added isValid field to Param. Modified all usages to use
isValid when relevant. Added helper methods in ParamValidate.
Also overrode Params.validate() in:
* CrossValidator + model
* Pipeline + model
This PR is Scala + Java only. Python will be in a follow-up PR.
CC: @mengxr
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark enforce-validate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5740.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5740
----
commit dc2061f0a51bc80dac030c925024c39b26614b91
Author: Joseph K. Bradley <[email protected]>
Date: 2015-04-27T18:03:53Z
merged with master. enforcing Params.validate
commit 57b8ad12b4082bc330c82e56d86a6e8669e440d0
Author: Joseph K. Bradley <[email protected]>
Date: 2015-04-27T21:01:05Z
Partly done with adding checks, but blocking on adding checking
functionality to Param
commit 8e368c712f6e4d5567b1274ba3e770af17a06a59
Author: Joseph K. Bradley <[email protected]>
Date: 2015-04-28T02:58:26Z
Still workin
commit d87278c211ea81f73a2a16f8e0ef282eefec0637
Author: Joseph K. Bradley <[email protected]>
Date: 2015-04-28T04:30:36Z
still workin
commit 26d327c08f4ac53c5e1e6719164e4bf32c413c9d
Author: Joseph K. Bradley <[email protected]>
Date: 2015-04-28T05:15:40Z
Maybe done
commit 39b036b2d622d4aa823db3fa24107a177ac6463a
Author: Joseph K. Bradley <[email protected]>
Date: 2015-04-28T05:40:16Z
many cleanups
commit f02c3c3ac1066e841615d07f2e003357b2f863f3
Author: Joseph K. Bradley <[email protected]>
Date: 2015-04-28T05:54:43Z
small cleanups
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
