Ngone51 commented on a change in pull request #31839:
URL: https://github.com/apache/spark/pull/31839#discussion_r594876024



##########
File path: core/src/main/scala/org/apache/spark/ContextCleaner.scala
##########
@@ -276,6 +287,16 @@ private[spark] class ContextCleaner(
     }
   }
 
+  def doCleanSparkListener(listener: SparkListener): Unit = {
+    try {
+      logDebug(s"Cleaning Spark listener $listener")

Review comment:
       It logs the qualified class name and JVM object id of that listener, 
e.g.,
   
   > Cleaning Spark listener 
org.apache.spark.sql.util.ExecutionListenerBus@54600fe
   
   I think it's enough for users to know which listener is removed.
   
   Others log their own ids because users can track them by analyzing the logs 
since Spark logs those ids in other places too. But Spark doesn't do that for 
listeners (and the listener itself doesn't have such an identifier or something 
else) so it should be enough for now. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to