cloud-fan commented on a change in pull request #31853:
URL: https://github.com/apache/spark/pull/31853#discussion_r595241016



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1147,16 +1152,10 @@ class Analyzer(override val catalogManager: 
CatalogManager)
         }
         // Fail the analysis eagerly because outside AnalysisContext, the 
unresolved operators
         // inside a view maybe resolved incorrectly.
-        // But for commands like `DropViewCommand`, resolving view is 
unnecessary even though
-        // there is unresolved node. So use the `performCheck` flag to skip 
the analysis check
-        // for these commands.

Review comment:
       This trick doesn't always work. Sometimes the analyzer may fail eagerly 
instead of waiting for `checkAnalysis`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to