Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5725#discussion_r29221149
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
    @@ -0,0 +1,74 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.unsafe.memory;
    +
    +import javax.annotation.Nullable;
    +
    +import org.apache.spark.unsafe.PlatformDependent;
    +
    +/**
    + * A consecutive block of memory, starting at a {@link MemoryLocation} 
with a fixed size.
    + */
    +public class MemoryBlock extends MemoryLocation {
    +
    +  private final long length;
    +
    +  /**
    +   * Optional page number; used when this MemoryBlock represents a page 
allocated by a
    +   * MemoryManager. This is package-private and is modified by 
MemoryManager.
    +   */
    +  int pageNumber = -1;
    +
    +  public int getPageNumber() {
    +    return pageNumber;
    +  }
    +
    +  MemoryBlock(@Nullable Object obj, long offset, long length) {
    +    super(obj, offset);
    +    this.length = length;
    +  }
    +
    +  /**
    +   * Returns the size of the memory block.
    +   */
    +  public long size() {
    +    return length;
    +  }
    +
    +  /**
    +   * Clear the contents of this memory block.  Returns `this` to 
facilitate chaining.
    +   */
    +  public MemoryBlock zero() {
    +    PlatformDependent.UNSAFE.setMemory(obj, offset, length, (byte) 0);
    +    return this;
    +  }
    +
    +  /**
    +   * Creates a memory block pointing to the memory used by the byte array.
    +   */
    +  public static MemoryBlock fromByteArray(final byte[] array) {
    --- End diff --
    
    can we remove this since it is not used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to