maropu commented on pull request #31747: URL: https://github.com/apache/spark/pull/31747#issuecomment-800668354
Yea, in the latest commit, I modified [the test itself](https://github.com/apache/spark/pull/31747/commits/bd7dbf044820281bd393a170a8d0347f2c3c6caf) and applied the #31709 fix so that the GA tests can pass. The modified test (`checkCompilationError`) just checks that the compilation fails with codegen enabled/disabled. If we merge this fix into branch-2.4, I think we need to apply the #31709 fix first, and then merge this in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
