Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/5134#issuecomment-96968051
  
    I don't think it's the correct way for this optimization. `Aggregate` takes 
the `output` of `Expand` for expression evaluation, not the `projections`!
    It probably need to refactor the `GroupingSet` a little bit before this 
optimization, I will submit soon.
    
    Sorry @viirya , I will ping you once the refactoring finished.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to