Ngone51 commented on a change in pull request #31152:
URL: https://github.com/apache/spark/pull/31152#discussion_r595801734
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/RowQueue.scala
##########
@@ -174,7 +174,8 @@ private[python] case class HybridRowQueue(
tempDir: File,
numFields: Int,
serMgr: SerializerManager)
- extends MemoryConsumer(memManager) with RowQueue {
+ extends MemoryConsumer(memManager, memManager.pageSizeBytes(),
memManager.getTungstenMemoryMode)
Review comment:
Why we need that constructor? Do you mean those on-heap consumers should
reuse the constructor then?
And after second thinking, I think the `MemoryConsumer` is better to require
the memory mode explicitly in any cases instead of setting a default one
silently. So I think we'd better remove the constructor which has the default
ON_HEAP mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
