Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5432#discussion_r29232672
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -41,9 +45,11 @@ private[history] abstract class
ApplicationHistoryProvider {
* Returns the Spark UI for a specific application.
*
* @param appId The application ID.
+ * @param attemptId The application attempt ID for apps with multiple
attempts (or an empty
+ * string for apps with a single attempt).
* @return The application's UI, or None if application is not found.
*/
- def getAppUI(appId: String): Option[SparkUI]
+ def getAppUI(appId: String, attemptId: String): Option[SparkUI]
--- End diff --
any reason not to use an `Option[String]` for `attemptId` here (and
everywhere else) as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
