c21 commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r596412016
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1254,21 +1254,38 @@ class AdaptiveQueryExecSuite
test("SPARK-34533: Eliminate left anti join to empty relation") {
withSQLConf(
SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
- withTable("emptyTestData") {
- spark.range(0).write.saveAsTable("emptyTestData")
- Seq(
- // broadcast non-empty right side
- ("SELECT /*+ broadcast(testData3) */ * FROM testData LEFT ANTI JOIN
testData3", true),
- // broadcast empty right side
- ("SELECT /*+ broadcast(emptyTestData) */ * FROM testData LEFT ANTI
JOIN emptyTestData",
- false),
- // broadcast left side
- ("SELECT /*+ broadcast(testData) */ * FROM testData LEFT ANTI JOIN
testData3", false)
- ).foreach { case (query, isEliminated) =>
- val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(query)
- assert(findTopLevelBaseJoin(plan).size == 1)
- assert(findTopLevelBaseJoin(adaptivePlan).isEmpty == isEliminated)
- }
+ Seq(
+ // broadcast non-empty right side
+ ("SELECT /*+ broadcast(testData3) */ * FROM testData LEFT ANTI JOIN
testData3", true),
+ // broadcast empty right side
+ ("SELECT /*+ broadcast(emptyTestData) */ * FROM testData LEFT ANTI
JOIN emptyTestData",
+ true),
Review comment:
This is true now as we eliminate join to its left side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
