sarutak commented on a change in pull request #31880:
URL: https://github.com/apache/spark/pull/31880#discussion_r596919236
##########
File path: pom.xml
##########
@@ -162,7 +162,9 @@
<commons.math3.version>3.4.1</commons.math3.version>
<!-- managed up from 3.2.1 for SPARK-11652 -->
<commons.collections.version>3.2.2</commons.collections.version>
- <scala.version>2.12.10</scala.version>
+ <scala-2.12.version>2.12.10</scala-2.12.version>
+ <scala-2.13.version>2.13.5</scala-2.13.version>
Review comment:
The first time I open this PR, `<scala.version>2.12.10</scala.version>`
is absent from the profile `<id>scala-2.12</id>` so, if we change the version
with `change-scala-version.sh 2.13`, there will be no more `2.12.10` because
`<scala.version>2.12.10</scala.version>` is overwritten with
`<scala.version>2.13.5</scala.version>.
Then, if we try to `change-scala-version.sh 2.12` will fail to modify
pom.xml.
If we have both versions in properties (`<scala-2.12.version>` and
`<scala-2.13-version>`) which will not be overwritten by
`change-scala-version.sh`, it's easy to choose `scala.version` to change.
But, as I mentioned above, now we don't need such properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
