Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/5694#issuecomment-97120034
I think as an initial refactoring, this is great. With this in place, we'll
be able to refactor other lengthy Bash scripts involved in the build into
Python, and add options that make it easy to run only specific groups of tests
(e.g. SQL, or GraphX, etc.) as we discussed.
As far as this PR is concerned, I think one final thing to do is test some
of the various failure modes that the script is supposed to cover:
* Add a random syntax error in one of the files
* Modify a test to always make it fail
* Drop a license header from one of the files
* etc.
For now you can do this manually by adding and then reverting commits to
this PR, but this can in the future perhaps be captured in some kind of
elementary script that tests the build itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
