cloud-fan commented on a change in pull request #31855:
URL: https://github.com/apache/spark/pull/31855#discussion_r597063626
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
##########
@@ -1538,4 +1539,52 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
TimestampType, YearMonthIntervalType)
}
}
+
+ test("SPARK-34761: add a day-time interval to a timestamp") {
+ val sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS", Locale.US)
+ for (zid <- outstandingZoneIds) {
+ val timeZoneId = Option(zid.getId)
+ sdf.setTimeZone(TimeZone.getTimeZone(zid))
+ checkEvaluation(
+ TimeAdd(
+ Literal(new Timestamp(sdf.parse("2021-01-01 00:00:00.123").getTime)),
+ Literal(Duration.ofDays(10).plusMinutes(10).plusMillis(321)),
Review comment:
can we test negative interval as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
