zhengruifeng commented on pull request #31889:
URL: https://github.com/apache/spark/pull/31889#issuecomment-802462693


   I also test using the two new agg in `LogisticRegressionSuite`, and all test 
passed except "multinomial logistic regression with intercept with L1 
regularization":
   
   existing 
[`interceptsRStd`](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala#L1816)
 is NOT equals to the [R 
coef](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala#L1753-L1779)
   
   To pass this case, I need to change `interceptsRStd` to the output of 
GLMNET. But I think this should be a good change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to