cloud-fan commented on a change in pull request #31857:
URL: https://github.com/apache/spark/pull/31857#discussion_r597696585
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1468,6 +1469,12 @@ object PushPredicateThroughJoin extends
Rule[LogicalPlan] with PredicateHelper {
case _ => false
}
+ private def pushDownJoinConditions(conditions: Seq[Expression], plan:
LogicalPlan) = {
+ conditions
+ .filterNot(_.semanticEquals(TrueLiteral)) // Push down true condition is
useless.
Review comment:
shouldn't this be optimized by `BooleanSimplification`? `true And cond`
-> `cond`
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1468,6 +1469,12 @@ object PushPredicateThroughJoin extends
Rule[LogicalPlan] with PredicateHelper {
case _ => false
}
+ private def pushDownJoinConditions(conditions: Seq[Expression], plan:
LogicalPlan) = {
+ conditions
+ .filterNot(_.semanticEquals(TrueLiteral)) // Push down true condition is
useless.
Review comment:
shouldn't this be optimized by `BooleanSimplification` already? `true
And cond` -> `cond`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
