AngersZhuuuu commented on a change in pull request #31611:
URL: https://github.com/apache/spark/pull/31611#discussion_r598388446
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -113,10 +113,15 @@ private[spark] class AppStatusStore(
}
}
- def stageData(stageId: Int, details: Boolean = false): Seq[v1.StageData] = {
+ def stageData(
+ stageId: Int,
+ details: Boolean = false,
+ withSummaries: Boolean = false,
Review comment:
> Right, but, why add two parameters to begin with? what are the
possible values of withSummaries that aren't implied by the value of details?
Hmm, one for metrics distribution summaries one for task details. They work
in different ways and do not affect each other.
Add tow parameters have two concern.
1. Some use may just want summaries metrics to get distribution and check
data skew but don't want task details data.
2. `details` parameter keeps consistence with origin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
