Ngone51 commented on a change in pull request #31919:
URL: https://github.com/apache/spark/pull/31919#discussion_r598411889
##########
File path: core/src/main/scala/org/apache/spark/ContextCleaner.scala
##########
@@ -172,18 +172,18 @@ private[spark] class ContextCleaner(
registerForCleanup(rdd, CleanCheckpoint(parentId))
}
- /** Register an object for cleanup. */
- private def registerForCleanup(objectForCleanup: AnyRef, task: CleanupTask):
Unit = {
- referenceBuffer.add(new CleanupTaskWeakReference(task, objectForCleanup,
referenceQueue))
- }
-
/** Register a SparkListener to be cleaned up when its owner is garbage
collected. */
def registerSparkListenerForCleanup(
listenerOwner: AnyRef,
listener: SparkListener): Unit = {
registerForCleanup(listenerOwner, CleanSparkListener(listener))
}
+ /** Register an object for cleanup. */
+ private def registerForCleanup(objectForCleanup: AnyRef, task: CleanupTask):
Unit = {
+ referenceBuffer.add(new CleanupTaskWeakReference(task, objectForCleanup,
referenceQueue))
+ }
+
Review comment:
Hi @dongjoon-hyun, this change intends to let the newly added
`registerSparkListenerForCleanup()` follow the same placement with other
`register...ForCleanup` methods. This would make the `ContextCleaner` looks
neater.
This is a style mistake made in the original PR so I fixed it in this
follow-up PR. Does it sound ok to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
