tanelk commented on a change in pull request #31927:
URL: https://github.com/apache/spark/pull/31927#discussion_r598885067
##########
File path:
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q70a.sf100/explain.txt
##########
@@ -207,7 +207,7 @@ Arguments: [rank(_w2#17) windowspecdefinition(s_state#10,
_w2#17 DESC NULLS LAST
(32) Filter [codegen id : 7]
Input [4]: [s_state#16, s_state#10, _w2#17, ranking#19]
-Condition : (isnotnull(ranking#19) AND (ranking#19 <= 5))
Review comment:
@cloud-fan This change here was the reason I started this PR. During
#31924 it was quite confusing why the `isnotnull` check was removed from some
plans and not from others. I spent quite a bit of time debuging, only to
discover that plan stability suite just did not update this plan, even though
it was changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
