cloud-fan commented on a change in pull request #31930:
URL: https://github.com/apache/spark/pull/31930#discussion_r599344401
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1889,13 +1889,27 @@ class Analyzer(override val catalogManager:
CatalogManager)
private def resolveExpression(
expr: Expression,
resolveColumnByName: Seq[String] => Option[Expression],
- resolveColumnByOrdinal: Int => Attribute,
+ resolveByOrdinalCandidates: () => Seq[Attribute],
Review comment:
This needs to be lazy because of `assert(q.children.length == 1)` in
https://github.com/apache/spark/pull/31930/files#diff-ed19f376a63eba52eea59ca71f3355d4495fad4fad4db9a3324aade0d4986a47R1988
We shouldn't fail if we don't need to resolve by ordinal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
